Bug Approval queue will trigger unexpected rebuilds when using filters

[Xon]

PHP:

$filters = $this->getQueueFilterInput();
$this->applyQueueFilters($unapprovedFinder, $filters);
...

if ($unapprovedItems->count() != $this->app->unapprovedCounts['total'])
{
    $approvalQueueRepo->rebuildUnapprovedCounts();
}

rebuildUnapprovedCounts will be unexpectedly called because unapprovedItems can be a limited unset of the the full list. Checking conditions on the finder isn't enough as there might be a required joins which are excluding things via a 3rd party...

Read more

Continue reading...