Solved BannedUsers spam check matches all users if Ip::convertIpStringToBinary returns false

[Steffen]

In the method XF\Spam\Checker\BannedUsers::check, if calling Ip::convertIpStringToBinary() returns false (*) then the finder call ->where('ip', $ip) builds the condition `xf_ip`.`ip` = 0 which MySQL evaluates to true for nearly all strings (see e.g. mysql: why comparing a 'string' to 0 gives true?). As a result, the query matches all banned users (not only those who have a matching IP address).

(*) What XenForo...

Read more

Continue reading...