Bug Extra space in TOTP url

[digitalpoint]

When generating the url for Google Authenticator (or other TOTP apps), there's an extra space before $user.

In XF\Tfa\Totp.php:
PHP:

$otpUrl = GoogleAuthenticator::getKeyUri('totp', "$issuer: $user", $config['secret'], null, [
   'issuer' => $issuer
]);

should be:
PHP:

$otpUrl = GoogleAuthenticator::getKeyUri('totp', "$issuer:$user", $config['secret'], null, [
   'issuer' => $issuer
]);

It's not normally noticeable, because Google Authenticator app cleans it up and trims it...

Read more

Continue reading...