Bug logSpamTrigger does not match getFinalDecision, resulting in the wrong action type being logged

[Xon]

The XF\Spam\AbstractChecker::logSpamTrigger computes a single discussion which doesn't match how XF\Spam\AbstractChecker::getFinalDecision implements it.

This can result in the spam log entry having the wrong spam trigger action. ie moderated vs denied.

Additionally logSpamTrigger skips logging on "accept" but, this doesn't match the API usage which can result in dropped logs.

Finally, it looks like logSpamTrigger will update the existing log entry (ie post gets...

Read more

Continue reading...