Place Your Ad Here

Bug logSpamTrigger does not match getFinalDecision, resulting in the wrong action type being logged

There is a bug in this version
X

Xon

Guest
The XF\Spam\AbstractChecker::logSpamTrigger computes a single discussion which doesn't match how XF\Spam\AbstractChecker::getFinalDecision implements it.

This can result in the spam log entry having the wrong spam trigger action. ie moderated vs denied.

Additionally logSpamTrigger skips logging on "accept" but, this doesn't match the API usage which can result in dropped logs.

Finally, it looks like logSpamTrigger will update the existing log entry (ie post gets...

Read more

Continue reading...
 
You must log in or register to reply here.

Similar threads

J
XenForo Why does XF Not consistently stop Chinese Spam
Replies
0
Views
21
XenForo Development & Modifications
JamesBrown
J
X
Solved does not match formatter pattern %s\Widget\%s ( version 2.2.16)
Replies
0
Views
27
XenForo General Discussions
XenCircle
X
X
Bug does not match formatter pattern %s\Widget\%s ( version 2.2.16)
Replies
0
Views
28
XenForo General Discussions
XenCircle
X
T
Solved Group user title does not override
Replies
0
Views
42
XenForo General Discussions
Tealk
T
F
Bug Group user title does not override (For 2.3.3)
Replies
0
Views
31
XenForo General Discussions
frm
F
Top Bottom
Back