Bug Search results are fetched twice

There is a bug in this version
X

Xon

Guest
\XF\Search\Searcher::search calls \XF\Search\Searcher::executeSearch will load the results, and puts it into a \XF\ResultSet to-do visibility checks, and then returns an array. Then the call to \XF\ResultSet::limitResults() will do that same again, loading the data and doing another view check.

This also applies to the main search, but since this is hidden behind a redirect it isn't immediately obvious.

PHP:

Code:
protected function executeSearch(
   Query\Query $query...

Read more

Continue reading...