Bug SearchController::convertShortSearchNames does not function as expected

[Xon]

There is dead code in convertShortSearchNames, and the order search argument is not preserved when a search is re-triggered.

PHP:

    protected function convertShortSearchNames(array $input)
    {
        $output = [];

...

        if (isset($input['o']))
        {
                $output['o'] = $input['o'] ?: null;
        }

        return $output;

        return [
            'search_type' => $input['t'] ?: null,
            'keywords' => $input['q'],
            'c' =>...

Read more

Continue reading...