Solved unassociatedAttachmentLimit calculated incorrectly

[mattrogowski]

Very minor issue but the unassociatedAttachmentLimit config value actually accepts 1 less than the limit. Easier to test if you set $config['unassociatedAttachmentLimit'] = 2;, you get the error after uploading 1 attachment instead of 2.

src/XF/Attachment/Manipulator.php:140:

$allowed = ($uploaded < $unassociatedLimit);

just needs to be:

$allowed = ($uploaded <= $unassociatedLimit);

Then it accepts 2 and rejects a 3rd.

Strangely the check above works...

Read more

Continue reading...