Bug XF\Mvc\Entity\Manager::getFinder does not always return a Finder

[Xon]

The XF\Mvc\Entity\Manager::getFinder function is type hinted to return a finder, but if an add-on does not implement the entity name as a short-string, this will fail and instead return the entity.

This will then give a misleading missing function message quite some distance from the root-cause.

Reproducer:

PHP:

namespace MyAddon\Entity;
class MyEntity extends \XF\Mvc\Entity\Entity
{
    public static function getStructure(Structure $structure): Structure
    {...

Read more

Continue reading...