Place Your Ad Here

Bug XF\Mvc\Entity\Manager\getFinder does not reliably return the same type depending on class extensions

There is a bug in this version
X

Xon

Guest
XenForo's dynamically creates finders of a given base-type if they are extended or otherwise will return a \XF\Mvc\Entity\Finder instance.

The problem is when return and parameter arguments are narrower than the \XF\Mvc\Entity\Finder and will cause a type error violation.
  • XenForo does not define XF\Finder\Warning
  • Add-on A extended XF\Finder\Warning
  • Add-on B has a return type hint of XF\Finder\Warning
  • Add-on...

Read more

Continue reading...
 
You must log in or register to reply here.

Similar threads

D
Solved Incorrect return type hint for \XF\Mvc\Entity\Manager::findByIds
Replies
0
Views
150
XenForo General Discussions
DragonByte Tech
D
D
Bug Incorrect return type hint for \XF\Mvc\Entity\Manager::findByIds
Replies
0
Views
134
XenForo General Discussions
DragonByte Tech
D
D
Solved Incorrect docblock for \XF\Mvc\Entity\Manager::instantiateEntity
Replies
0
Views
139
XenForo General Discussions
DragonByte Tech
D
D
Bug Incorrect docblock for \XF\Mvc\Entity\Manager::instantiateEntity
Replies
0
Views
141
XenForo General Discussions
DragonByte Tech
D
M
Solved ErrorException: [E_WARNING] Undefined array key "" src/XF/Mvc/Entity/Manager.php:584
Replies
0
Views
235
XenForo General Discussions
MattW
M
Top Bottom
Back