Place Your Ad Here

Bug \XF\Util\Color::isValidColor() produces a positive match for RGB values without commas, can break CS

There is a bug in this version
A

apathy

Guest
The regex used in this function is capable of producing a positive match when an RGB value without commas is entered - regex101 example

This can cause problems when creating Reactions for instance, if a comma-less RGB value is specified for the reaction text color, the CSS can break like in the attached screenshot.

Usually this wouldn't be a huge problem since I imagine most admins are using the color picker (which correctly produces commas), however some of my addons and I imagine...

Read more

Continue reading...
 
You must log in or register to reply here.

Similar threads

P
Solved InvalidArgumentException: Invalid string IP: e\v in src/XF/Util/Ip.php at line 17
Replies
0
Views
69
XenForo General Discussions
Phun
P
D
Bug Wrong return hint for \XF\Util\Ip::checkIpsAgainstBinaryRangeList
Replies
0
Views
92
XenForo General Discussions
DragonByte Tech
D
K
Solved \XF\Util\Random::getRandomString() seems suspectible to timing attacks
Replies
0
Views
181
XenForo General Discussions
Kirby
K
K
Bug \XF\Util\Random::getRandomString() seems suspectible to timing attacks
Replies
0
Views
179
XenForo General Discussions
Kirby
K
J
XenForo [E_WARNING] mkdir(): Permission denied in src/XF/Util/File.php at line 281
Replies
0
Views
279
XenForo Development & Modifications
Jean-Baptiste
J
Top Bottom
Back