Bug \XF\Validator\Username::setupOptionDefaults overrides visibility

[PaulB]

\XF\Validator\Username::setupOptionDefaults is public, but \XF\Validator\Username::setupOptionDefaults is protected. There doesn't seem to be any need to override the visibility; the former could be protected.

This is a good candidate to resolve in 2.3.x, as resolving it is technically a breaking change, albeit a minor one.

Continue reading...