Place Your Ad Here

Bug XFES's FunctionOrder & Query::orderedBy() type hint incompatibility

There is a bug in this version
X

Xon

Guest
XFES uses XFES\Search\Query\FunctionOrder in some cases which is passed to orderedBy. However has the signature; Query::orderedBy(string|SqlOrder $order) :: static.

This gives a false positive about an incompatible argument type

It would be nice if FunctionOrder had a common base that was accepted by Query::orderedBy. That is FunctionOrder and SqlOrder should descend from a common base class.

Continue reading...
 
You must log in or register to reply here.

Similar threads

F
Bug "Please enter a valid value" (for XFES and may apply to XF where whole numbers aren't required)
Replies
0
Views
29
XenForo General Discussions
frm
F
B
XenForo Advanced Search with Elasticsearch (XFES)
Replies
0
Views
327
XenForo Development & Modifications
bernhard84
B
R
XenForo How to move XFES Similar Threads widget under 1st post on each thread page?
Replies
0
Views
450
XenForo Development & Modifications
rdn
R
T
Solved XenForo Enhanced Search 2.2.2 unknown query [type] src/addons/XFES/Elasticsearch/Api.php:424
Replies
0
Views
766
XenForo General Discussions
TAIFUN
T
S
Bug XenForo Enhanced Search 2.2.2 unknown query [type] src/addons/XFES/Elasticsearch/Api.php:424
Replies
0
Views
626
XenForo General Discussions
Sergio Bambaren
S
Top Bottom
Back