Bug Incorrect ArrayCollection type-hint on some methods

[Xon]

The following methods are type hinted as ArrayCollection which should be AbstractCollection as they can return FinderCollection;

• \XF\Mvc\Entity\Finder::getIterator
• \XF\Mvc\Entity\Manager::findByIds

\XF\Mvc\Entity\Manager also has the methods getBasicCollection and getEmptyCollection which probably should be type hinted AbstractCollection as well.

Continue reading...