Bug Incorrect ArrayCollection type-hint on some methods

  • Thread starter Thread starter Xon
  • Start date Start date
There is a bug in this version
X

Xon

Guest
The following methods are type hinted as ArrayCollection which should be AbstractCollection as they can return FinderCollection;
  • \XF\Mvc\Entity\Finder::getIterator
  • \XF\Mvc\Entity\Manager::findByIds
\XF\Mvc\Entity\Manager also has the methods getBasicCollection and getEmptyCollection which probably should be type hinted AbstractCollection as well.

Continue reading...
 
You must log in or register to reply here.
Top Bottom
Back